Rename rawTransaction to rawTx in the persisted transaction metadata#1624
Rename rawTransaction to rawTx in the persisted transaction metadata#1624vinistevam merged 2 commits intomainfrom
Conversation
32f5491 to
7aa30a7
Compare
|
What is the motivation for doing the change here, as opposed to doing the inverse change in downstream extension? Second, if this is indeed the way to go, would it be feasible to expose the same identical value as both names? AIUI this is a pretty significant API-breakage and doing it this way would allow an easier and safer upgrade path for downstreams, where full deprecation can happen at a later point. |
7aa30a7 to
871cd1c
Compare
Thanks for bringing that up, the decision was mainly motivated to mitigate risk as the extension is using |
871cd1c to
4cfe84b
Compare
…rawTx (#7264) This PR aims to adopt the changes in core renaming `rawTransation` to `rawTx`. The change is part of an effort to align the extension and core controller towards unification. - Generated the patch with the changes to rename the properties - Add migration and tests to properly rename This was merged in the TransactionController in the core repo by PR MetaMask/core#1624 .
Explanation
Rename the
rawTransactionproperty torawTxin the persisted transaction metadata as part of the unification initiative between the core and extension.The following task will take place to handle the migration and adoption of the patch/release.
References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/1080
Changelog
@metamask/transaction-controllerrawTransactionproperty torawTxin the persistedTransactionMeta.Checklist